Add precommit configuration and apply settings to files and fix typos#384
Add precommit configuration and apply settings to files and fix typos#384iranzo wants to merge 1 commit into
Conversation
|
✔️ Deploy Preview for microshift ready! 🔨 Explore the source changes: 154f363 🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/61823a3662547f00085da897 😎 Browse the preview: https://deploy-preview-384--microshift.netlify.app |
|
Hi @iranzo. Thanks for your PR. I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
/retest |
1 similar comment
|
/retest |
|
/assign rootfs |
|
/test e2e-openshift-conformance-sig-api-machinery |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Rebased on top of branch |
|
I see no issues with this once its caught up sorry @iranzo for making you have to fix conflicts again |
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
|
@iranzo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@iranzo I'm singing 🎵 This is the PR that never ends....it just goes on and on my friend 🎵 |
|
Dump it :-)
--
Pablo Iranzo Gómez
GnuPG: 0x5BD8E1E4
Web: https://iranzo.io || https://t.me/redken_bot
El mié, 3 nov 2021 a las 18:03, Ryan Cook ***@***.***>)
escribió:
… @iranzo <https://github.com/iranzo> I'm singing 🎵 This is the PR that
never ends....it just goes on and on my friend 🎵
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#384 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMJDZ2NYLTF55KRL6VAITUKF2QZANCNFSM5G2A5Y3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
4 participants
This PR adds precommit as well as some of the opinionated formatters